[WC-3073] selection helper ticket #1920
Open
+147
−349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the selection helper widget to use MobX for better state management and reactivity. The changes modernize the context API to directly expose the MobX-enabled MultiSelectionHelper and update the SelectionHelper component to be a MobX observer.
- Adds MobX observability to MultiSelectionHelper class with proper observable/computed/action decorators
- Simplifies the context API to directly expose the selection helper instead of a custom wrapper object
- Updates the SelectionHelper component to use MobX observer pattern for reactive rendering
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/shared/widget-plugin-grid/src/selection/helpers.ts | Adds MobX decorators to MultiSelectionHelper and implements togglePageSelection method |
| packages/shared/widget-plugin-grid/src/selection/context.ts | Simplifies context API to directly expose SelectionStore interface |
| packages/pluggableWidgets/selection-helper-web/src/package.xml | Updates version from 3.3.0 to 3.6.1 |
| packages/pluggableWidgets/selection-helper-web/src/components/SelectionHelperComponent.tsx | Adds TODO comment and reorders imports |
| packages/pluggableWidgets/selection-helper-web/src/SelectionHelper.tsx | Converts component to MobX observer and updates property access |
| packages/pluggableWidgets/selection-helper-web/package.json | Updates version and adds mobx-react-lite dependency |
| packages/pluggableWidgets/selection-helper-web/CHANGELOG.md | Adds changelog entry for checkbox state synchronization fix |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
gjulivan
approved these changes
Oct 2, 2025
iobuhov
force-pushed
the
3073_selection_helper_ticket
branch
from
1e2d9b0 to
4eb380e
Compare
samuelreichert
approved these changes
Oct 7, 2025
|
Needs rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Fix issue with checkbox state by making it observable